Trie.remove(nonexistent-node) is a no-op

jupyterhub · Jan 26, 2017 · 8ccdae9 · 8ccdae9
1 parent 815c248
commit 8ccdae9
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/trie.js b/lib/trie.js
@@ -75,6 +75,11 @@ URLTrie.prototype.remove = function (path) {
     }
     var part = path.shift();
     var child = this.branches[part];
+    if (child === undefined) {
+        // Requested node doesn't exist,
+        // consider it already removed.
+        return;
+
     child.remove(path);
     if (child.size === 0 && child.data === undefined) {
         // child has no branches and is not a leaf