Omit configuration of oauth_client_id, rely on its default value

jupyterhub · Oct 12, 2022 · 681466c · 681466c
1 parent 751e785
commit 681466c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/doc/authentication.rst b/doc/authentication.rst
@@ -26,7 +26,6 @@ you need to add the following into ``config.yaml``:
           binder:
             oauth_no_confirm: true
             oauth_redirect_uri: "https://<binderhub_url>/oauth_callback"
-            oauth_client_id: "binder-oauth-client-test"
 
       singleuser:
         # to make notebook servers aware of hub

diff --git a/testing/local-binder-k8s-hub/binderhub_config_auth_additions.py b/testing/local-binder-k8s-hub/binderhub_config_auth_additions.py
@@ -25,4 +25,4 @@
 c.HubOAuth.base_url = c.BinderHub.base_url
 c.HubOAuth.hub_prefix = c.BinderHub.base_url + "hub/"
 c.HubOAuth.oauth_redirect_uri = "http://127.0.0.1:8585/oauth_callback"
-c.HubOAuth.oauth_client_id = "binder-oauth-client-test"
+c.HubOAuth.oauth_client_id = "service-binder"
diff --git a/testing/local-binder-k8s-hub/jupyterhub-chart-config-auth-additions.yaml b/testing/local-binder-k8s-hub/jupyterhub-chart-config-auth-additions.yaml
@@ -6,7 +6,6 @@ hub:
     binder:
       oauth_no_confirm: true
       oauth_redirect_uri: "http://127.0.0.1:8585/oauth_callback"
-      oauth_client_id: "binder-oauth-client-test"
   config:
     JupyterHub:
       authenticator_class: "dummy"