Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group emitted logs for readability #31

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Oct 3, 2021

Currently includes #29 to avoid merge conflicts and be tested with that.

Running into a failure to await trafik it seems. I note that the more recent k8s versions involve a job to install the traefik helm chart etc. See https://rancher.com/docs/k3s/latest/en/networking/.


After this, it may look something more like this.

image

@consideRatio consideRatio force-pushed the pr/make-reliable branch 7 times, most recently from a5d3c43 to a51b25d Compare October 3, 2021 22:48
@consideRatio consideRatio changed the title Group log lines Group emitted logs for readability Oct 3, 2021
@consideRatio consideRatio added the enhancement New feature or request label Oct 3, 2021
@consideRatio
Copy link
Member Author

@manics I rebased this on top of the other two PRs!

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly the first line of the run block is still shown
image
I presume there's nothing we can do about that? If so go ahead and merge!

@consideRatio
Copy link
Member Author

consideRatio commented Oct 4, 2021

Annoyingly the first line of the run block is still shown

I don't think there is something we can do about it, but I also wonder if that will show in the end when this action is run from a remote repo.

Also, I wonder, perhaps its relevant to have those in the end even though they are named ugly. They show the commands run, and the others show the output.

@consideRatio consideRatio merged commit 73c0f9b into jupyterhub:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants