Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clipping plane and exploded view icons #474

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Add clipping plane and exploded view icons #474

merged 6 commits into from
Oct 16, 2024

Conversation

IsabelParedes
Copy link
Contributor

@IsabelParedes IsabelParedes commented Oct 15, 2024 •
edited
Loading

Inspo:

Icons:

@SylvainCorlay
Copy link
Member

For the clipping plane, how about making the clipping plane a bit larger and removing the back of the cube?

376754771-1f822ead-26db-4d37-8afe-017f5e029736

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Integration tests repot: appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Preview PR at appsharing.space

@trungleduc
Copy link
Member

trungleduc commented Oct 15, 2024 •
edited
Loading

Thanks @IsabelParedes. I pushed an update to get the preview link.

cad22

@SylvainCorlay
Copy link
Member

A new version closer to the original, with square angles on the cut part of the cube.

Original:

clipping

Png:

cube

@arjxn-py
Copy link
Member

376816413-b7a93e91-aa2a-4f86-a040-6f04ddb77f60 1

Thanks @SylvainCorlay, Here's an SVG for the same :)

@SylvainCorlay
Copy link
Member

Ah yes, the first attachment that appeared very small was already an svg.

@arjxn-py
Copy link
Member

Ah yes, the first attachment that appeared very small was already an svg.

Oh oops, my bad 😅

@martinRenou martinRenou added this to the 3.0.0 milestone Oct 16, 2024
@IsabelParedes IsabelParedes marked this pull request as ready for review October 16, 2024 08:10
@IsabelParedes IsabelParedes marked this pull request as draft October 16, 2024 08:24
@IsabelParedes IsabelParedes marked this pull request as ready for review October 16, 2024 08:32
@IsabelParedes
Copy link
Contributor Author

Thanks for all the feedback!

image

image

arjxn-py
arjxn-py approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IsabelParedes, these looks awesome 🚀

martinRenou
martinRenou approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@martinRenou martinRenou merged commit 61f9d8c into jupytercad:main Oct 16, 2024
10 checks passed
@IsabelParedes IsabelParedes deleted the icons branch October 16, 2024 11:38
@martinRenou martinRenou added the enhancement New Feature or improvement label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

@arjxn-py arjxn-py arjxn-py approved these changes

Assignees
No one assigned
Labels
enhancement New Feature or improvement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@IsabelParedes @SylvainCorlay @trungleduc @arjxn-py @martinRenou