Fix breaking viewHelper while changing camera #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjxn-py
force-pushed
the
fix-viewhelper
branch
from
4b2dffe
to
b8929d4
Compare
|
Integration tests repot: appsharing.space |
|
Preview PR at appsharing.space |
trungleduc
reviewed
Oct 11, 2024
arjxn-py
force-pushed
the
fix-viewhelper
branch
from
738d099
to
bdf1aff
Compare
martinRenou
reviewed
Oct 15, 2024
| ); | ||
| } | ||
| }; | ||
| this.divRef.current?.appendChild(this._viewHelperDiv); |
There was a problem hiding this comment.
Just a question, how are we removing the old one now?
There was a problem hiding this comment.
We're not removing it now as it was not necessary, just updating it with updateCamera works.
There was a problem hiding this comment.
What I mean is that you re-create a new this._viewHelperDiv in updateCamera, that you append to this.divRef.current.
Don't we need to remove the old this._viewHelperDiv that was created before?
There was a problem hiding this comment.
Yes you're right, I just verified. Sorry that I overlooked, I'll be omw to fix it.
There was a problem hiding this comment.
Done in 4602e00
Thank You for pointing this out :)
arjxn-py
force-pushed
the
fix-viewhelper
branch
from
b365ff0
to
4602e00
Compare
martinRenou
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463
vh.mov