Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add ViewHelper #435

Closed
wants to merge 12 commits into from
Closed

WIP: Add ViewHelper #435

wants to merge 12 commits into from

Conversation

arjxn-py
Copy link
Member

No description provided.

arjxn-py and others added 4 commits September 18, 2024 16:06
@arjxn-py
add viewHelper
321b1f5 
[not functioning properly]
@arjxn-py
Use GizmoOptions to validate
9c16625
@martinRenou @pre-commit-ci
Include Notebook API into lite kernel deployment (jupytercad#364)
e3b8a81 
* Include Notebook API into lite deployment

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Try installing the whl directly

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Non needed deps

* Try renaming the whl for pip to not complain

* Fixup

* Formatted whl file name

* Debug

* Pin empack

* Pin pydantic

* Update environment.yml

* Dumby dumb

* Add jupyter shared drives

* Add signaling server config

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@martinRenou @pre-commit-ci
Lite deployment: Disable docprovider-extension (jupytercad#433)
d677d48 
* Lite deployment: Disable docprovider-extension

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@arjxn-py arjxn-py marked this pull request as draft September 19, 2024 15:46
pre-commit-ci bot and others added 2 commits September 19, 2024 15:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Preview PR at appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Integration tests repot: appsharing.space

@martinRenou
Copy link
Member

I'm excited about this! 😄

This may be an opportunity for getting rid of the Axis helper thingy, as I believe we won't need it with these changes?

@arjxn-py
Copy link
Member Author

I'm excited about this! 😄

So am I, and as I mentioned it was not looking good before as it was messing with the scene by rendering it skewed. After good amount of time spent it's atleast looking better than that but still not in the best shape to be ready, there are a couple of issues which I'm wondering, why?

jcad-vh.mov

  • There's this strange offset to the viewHelper you can notice while i hover over it & inspite of me giving it top-right position, the div container of viewHelper is in top right but viewHelper in the scene is not.
    image

  • ViewHelper is not visible when left panel is on and even if it's off it's still not fully visible maybe due to still some space in the left?

This may be an opportunity for getting rid of the Axis helper thingy, as I believe we won't need it with these changes?

Yes I agree, this can be a good option for axis helper too. :)

@arjxn-py
Copy link
Member Author

arjxn-py commented Oct 1, 2024

Superseded by #440

@arjxn-py arjxn-py closed this Oct 1, 2024
@arjxn-py arjxn-py deleted the viewHelper branch October 2, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arjxn-py @martinRenou