Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #407

Closed
wants to merge 1 commit into from
Closed

Update dependencies #407

wants to merge 1 commit into from

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Sep 10, 2024 •
edited
Loading

Discussed in #405
Changes are auto-generated with jlpm install locally

martinRenou
martinRenou reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised by one of the changes, also when I try jlpm install locally it does not seem to change the lock file for me. I'm not sure what's different in your setup

yarn.lock Show resolved Hide resolved
@arjxn-py
Copy link
Member Author

Oh, it works.
I guess it was an issue locally while switching branches, seems like package.json was incorrectly overwritten. Apologies.

@arjxn-py arjxn-py closed this Sep 10, 2024
@martinRenou
Copy link
Member

No worries, thanks for checking!

@arjxn-py arjxn-py deleted the update-deps branch September 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou left review comments

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arjxn-py @martinRenou