Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shape metadata update logic #385

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Jul 24, 2024

Fixes #384

jcad.mp4

Code change

  • Shape metadata is updated at the same time as the shape parameters
  • Add tests for Undo and Redo function

Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/update-schema

@trungleduc trungleduc marked this pull request as draft July 24, 2024 10:51
@trungleduc trungleduc changed the title Update JCAD schema Improve shape metadata update logic Jul 29, 2024
@trungleduc trungleduc marked this pull request as ready for review July 29, 2024 14:57
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this branch locally & it works seamlessly.
I would also want to suggest a couple of very minor improvements if that's ok.
Thanks a lot @trungleduc

packages/base/src/commands.ts Show resolved Hide resolved
packages/base/src/commands.ts Show resolved Hide resolved
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @trungleduc ! And thanks for the review @arjxn-py 🚀

@martinRenou martinRenou merged commit 3fee6cf into jupytercad:main Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend undo manager
3 participants