Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deletion behavior #369

Merged
merged 8 commits into from
Jun 26, 2024
Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jun 26, 2024

Fix #339

Removing objects now result in opening a dialog showing all the objects that will get deleted in the process if there are dependants operators.

Screencast.from.2024-06-26.10-16-41.mp4

Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/deleting_objects

@SylvainCorlay
Copy link
Member

This is great! I think this will make 2.0 a lot more solid in terms of user experience.

@martinRenou
Copy link
Member Author

There is still one thing to figure out, it's updating the dependencies entry in the object properties panel if Base/Tool/Shapes gets updated. Not sure there is a generic approach we can take here.

@trungleduc do you have ideas for that?

@trungleduc
Copy link
Member

we expand recursively the operator in the worker (

export function expand_operator(
). You can use this data to set the dependencies?

@martinRenou
Copy link
Member Author

martinRenou commented Jun 26, 2024

I'm handling updating object properties now:

Screencast.from.2024-06-26.11-30-36.mp4

@martinRenou martinRenou marked this pull request as ready for review June 26, 2024 09:32
@trungleduc
Copy link
Member

Thanks!

@trungleduc trungleduc merged commit dabfb28 into jupytercad:main Jun 26, 2024
9 checks passed
@martinRenou martinRenou deleted the deleting_objects branch June 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent delete objects being used in other operators
3 participants