Skip to content

Commit

Permalink
Add lint command
Browse files Browse the repository at this point in the history
  • Loading branch information
trungleduc committed Apr 26, 2023
1 parent 7462f81 commit bb5d0fa
Show file tree
Hide file tree
Showing 27 changed files with 8 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {
],
parser: '@typescript-eslint/parser',
parserOptions: {
project: 'tsconfig.json',
project: 'tsconfig.eslint.json',
sourceType: 'module'
},
plugins: ['@typescript-eslint'],
Expand Down
13 changes: 0 additions & 13 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

# Use mamba instead due to freecad
#- name: Base Setup
# uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
#- name: Install dependencies
# run: python -m pip install -U jupyterlab>=0.4.0b0

- name: Install Conda environment with Micromamba
uses: mamba-org/provision-with-micromamba@main
with:
Expand All @@ -40,13 +34,6 @@ jobs:
jlpm
jlpm run lint:check
# We don't have tests
#- name: Test the extension
# shell: bash -l {0}
# run: |
# set -eux
# jlpm run test

- name: Build the extension
shell: bash -l {0}
run: |
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
"eslint:check": "eslint . --ext .ts,.tsx",
"prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
"prettier:check": "prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
"lint:check": "jlpm run prettier:check && jlpm run eslint:check",
"lint": "jlpm run prettier && jlpm run eslint",
"test": "lerna run test"
},
"resolutions": {
Expand Down
5 changes: 5 additions & 0 deletions tsconfig.eslint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"extends": "./tsconfigbase",
"include": ["packages/**/*", "ui-tests"],
"types": ["jest"]
}
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit bb5d0fa

Please sign in to comment.