More unit tests #8
Conversation
Test case for named terminal, given no name
…st case (can't do Tornado co-routines in __init__)
Add test cases for testing maximum terminals
| @tornado.testing.gen_test | ||
| def test_basic_command(self): | ||
| for url in self.test_urls: | ||
| tm = yield self.get_term_client('/named/foo') |
There was a problem hiding this comment.
Shouldn't this be passed url instead of '/named/foo'?
|
|
||
| @tornado.testing.gen_test | ||
| def test_max_terminals(self): | ||
| urls = ["/named/%d" % i for i in range(MAX_TERMS+1)] |
There was a problem hiding this comment.
Since this is probably going to be relatively slow, let's skip this test until there's a way of checking that the final one isn't created.
There was a problem hiding this comment.
What do you consider slow? This whole case finishes in a few seconds, at most. I could drop MAX_TERMs to 2 or 3?
There was a problem hiding this comment.
I just mean that since this test doesn't currently create the (N+1)th terminal, it's not really checking anything that isn't checked elsewhere, so we may as well leave it out until we work out how to test what it aims to test.
There was a problem hiding this comment.
Ah, I see what you mean. See the lines below both max_terminals tests (FIXME): the MAX_TERM+1 case is commented out because of bugs (e.g. #9).
If this PR otherwise looks good to you, after you accept it, I'll send modular individual PRs (e.g. unit test case demonstrating the bug + the fix) for these other issues.
There was a problem hiding this comment.
OK, great. Yes, I think this otherwise looks good - thanks!
| def test_max_terminals(self): | ||
| tms = yield self.get_term_clients(['/unique'] * MAX_TERMS) | ||
| pids = yield self.get_pids(tms) | ||
| self.assertEqual(len(set(pids)), MAX_TERMS) # All PIDs the same |
|
Hmm, after I merged this, there were some test failures: https://travis-ci.org/takluyver/terminado/builds/50237451 Can you take a look? |
|
There is some racing happening on the timeouts. The Travis environment seems especially sensitive to time variances. Can you kick it off again? In the meantime, I will widen some of the timeouts. -andy
|
|
More liberal read timeouts: #10 Sorry for the noise on this one. |
Added methods to read all pending message and all pending stdout
Added simple test case for a shell command (whoami)
Tests run on all terminal manager types
Test case for named terminal manager with no name provided