Fix for https://github.com/jupyter/terminado/issues/62 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jupyter brings in latest tornado version 6.0.1 and it breaks Jupyter Terminal due to removing of gen.Task in earlier version, https://www.tornadoweb.org/en/stable/releases/v6.0.0.html
|
Commit which deprecated gen Task in Tornado, tornadoweb/tornado@647aed6#diff-de74a7539d554a40178984aa0f1f35dd |
|
For Build failures its due to 'Build execution time has reached the maximum allowed time for your plan (60 minutes).' but actual tests passed. |
|
@blink1073 it looks like all the recent Windows tests have failed in a similar way for several months. Do you want to debug them? If not, I'm inclined to just disable them. |
|
Closing/reopening to rerun tests |
Thanks the new tests are passing. Is it good to merge? |
|
Thanks, I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyter brings in latest tornado version 6.0.1 and it breaks Jupyter Terminal due to removing
of gen.Task in earlier version, https://www.tornadoweb.org/en/stable/releases/v6.0.0.html