Add support for Windows #44
Conversation
terminado/management.py
Outdated
| @@ -155,23 +167,36 @@ def new_terminal(self, **kwargs): | |||
| argv = options['shell_command'] | |||
| env = self.make_term_env(**options) | |||
| pty = PtyProcessUnicode.spawn(argv, env=env, cwd=options.get('cwd', None)) | |||
| if os.name == 'nt': | |||
There was a problem hiding this comment.
This will go away pending a new release of pywinpty
|
cc @ellisonbg |
pyproject.toml
Outdated
| @@ -9,7 +9,8 @@ author-email = "[email protected]" | |||
| home-page = "https://github.com/takluyver/terminado" | |||
| description-file = "README.rst" | |||
| requires = [ | |||
| "ptyprocess", | |||
| "ptyprocess;os_name==posix", | |||
| "pywinpty;os_name==nt,python_version>='3.0'", | |||
There was a problem hiding this comment.
I think posix and nt need to be in quotes - see https://www.python.org/dev/peps/pep-0345/#environment-markers
pyproject.toml
Outdated
| "ptyprocess;os_name==posix", | ||
| "pywinpty;os_name==nt,python_version>='3.0'", | ||
| "ptyprocess;os_name=='posix'", | ||
| "pywinpty;os_name=='nt',python_version>='3.5'", |
There was a problem hiding this comment.
Thanks. I'm just looking through the spec, and I think the way to combine expressions is with and, rather than comma. I've opened an issue on flit to validate these markers at build time. pypa/flit#152
|
@takluyver, we have all of our dependencies, can you please set up appveyor for this repo? |
|
Actually, only the win32 wheels are published so far. |
|
I just saw the mailing list post, cancel my request for appveyor here ;). |
|
@blink1073 I'm having some queueing problems with AppVeyor, The wheels for 0.4.1 should be published tomorrow (Central Europe Time) or during the night on America |
|
Great, thanks! |
|
@andfoy would you mind restarting the build? Feodor from Appveyor says it should be good to go. |
|
@blink1073 I've just retried without any success, I've already posted a response on the ticket. |
|
@blink1073 Success! I'll make the release then |
Update appveyor docs fix test turn build off Add pytest dep Set the path specify python 3 only for windows syntax clean up requirements Remove unused import Fix handling of eof and unique term manager eof is already raised Clean up terminate and client_disconnected Use forthcoming API Remove unused imports specify the signals for terminate cleanup specificy pywinpty version Fix version specifiers update specs Update dependency
|
@takluyver, ready when you are! |
|
Thanks both! @blink1073 do you want upload permissions on PyPI? If so, what's your PyPI username? With flit installed, it should be just a case of running |
|
Sure, it is blink1073 there as well.
Sent from phone
…________________________________
From: Thomas Kluyver <[email protected]>
Sent: Friday, November 24, 2017 9:06:39 AM
To: jupyter/terminado
Cc: Steven Silvester; Mention
Subject: Re: [jupyter/terminado] Add support for Windows (#44)
Thanks both!
@blink1073<https://github.com/blink1073> do you want upload permissions on PyPI? If so, what's your PyPI username? With flit installed, it should be just a case of running flit publish .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#44 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB_99KGQmOTBDb0GHNfmeJZtCv8akHU4ks5s5tt_gaJpZM4QjC-o>.
|
|
Done :-) |
|
Verified in a fresh conda env in JupyterLab:
|
|
Just noticed the Home Page on pypi is still pointing to @takluyver's repo:
It might be an idea to change that so support questions got to the right place. |
|
Good catch! See #47. |
|
I also opened #46 in case it's useful! 😄 |
Relies on andfoy/pywinpty#67 and a release.
Note this is for Python 3 only because
pywinptydoes not support Python 2.Here's a screenshot with
export SHELL=`which cmd`:Here it is with
export SHELL=`which bash`:Passing build on https://ci.appveyor.com/project/blink1073/terminado/build/1.0.7
I can take care of any Windows related maintenance issues moving forward.