Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication in PtyWithClients.terminate #43

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Reduce duplication in PtyWithClients.terminate #43

merged 1 commit into from
Nov 15, 2017

Conversation

srstevenson
Copy link
Contributor

No description provided.

@takluyver takluyver closed this Nov 15, 2017
@takluyver takluyver reopened this Nov 15, 2017
@takluyver takluyver merged commit ebac2d7 into jupyter:master Nov 15, 2017
@srstevenson srstevenson deleted the reduce-duplication branch November 15, 2017 14:17
@takluyver
Copy link
Member

Thanks! Is there anything else you're planning to work on in the near future, or shall I put together a new release?

@srstevenson
Copy link
Contributor Author

I don't have any other changes in mind; I just came across these two whilst reading to see how terminado works.

@takluyver
Copy link
Member

OK, great. It's been a while since the last release, so I'm going to put together 0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srstevenson @takluyver