Send SIGHUP to the process group in the terminal, not just the leader #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firejail is still around. Doesn't seem to fix the issue. |
|
Myeh. Maybe part of its sandboxing involves launching the child in a new process group, so it still doesn't get the signal. Have a look for any options for firejail to quit on SIGHUP. Or work out if there's something else you can do to make it quit, e.g. another signal. If so, you can subclass UniqueTermManager and override its |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-37
@sknepal could you try this out and see if it fixes your issue with firejail?