keep websocket connection alive by sending pings when there is no activity #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ping message perodically when there is no activity
| @@ -56,6 +63,26 @@ def initialize(self, term_manager): | |||
|
|
|||
| self._logger = logging.getLogger(__name__) | |||
|
|
|||
| self.keep_alive_time = 5 #send a ping if there is no activity for more than this many of seconds | |||
| self.last_activity_time = keep_alive_time | |||
There was a problem hiding this comment.
These assignments don't look quite right - shouldn't it be self.keep_alive_time = keep_alive_time? And I guess last_activity_time should be set to 0 here.
|
I just made changes based on takluyver's suggestions |
|
|
||
| def send_json_message(self, content): | ||
| json_msg = json.dumps(content) | ||
| self.write_message(json_msg) | ||
| self.__update_last_activity_time() |
There was a problem hiding this comment.
Similarly for these, can they go inside an if self.keep_alive_time > 0 block?
|
Thanks. Just a few formatting comments now, and then it's good. |
|
I just updated as requested. Thanks |
|
Thanks! |
takluyver
added a commit
that referenced
this pull request
Feb 6, 2016
keep websocket connection alive by sending pings when there is no activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use nginx as a reverse proxy in front of terminado and jupyter. One issue I am having is that after there is no activity in the web terminal window for more than 60 seconds (default timeout in nginx), nginx will close the connection. This pull request is to add a feature to terminado to perodically send websocket "ping" frames when there is no activity. For example, if we set the keep_alive_time to 5 seconds, we will send a "ping" message when there is no activity for more than 5 seconds, No ping message will be sent when there is activity to conserve bandwidth.