-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test ConPTY backend against pywinpty 2.0.5 #146
Conversation
@blink1073, this is mostly a concurrency error, the time it takes to kill the process is larger than the time that it takes to set the closed attribute. In this case, we would like to have a thread-safe behaviour here. So we either wait a little bit before asserting that the process is down, or we make the access to the |
I think it is fair to add an |
I thought that the |
According to https://stackoverflow.com/a/41464804/1143629, we shouldn't be polling with |
d841366
to
47ce418
Compare
@blink1073 this is now working as expected |
I'm thinking we should rely on the env variable to set the backend, since there isn't yet a way to configure this setting using traits. |
(so remove lines 49 and 50 altogether) |
@blink1073, done |
Cool, thanks! |
No description provided.