Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly set the TERM variable #117

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

rvalieris
Copy link
Contributor

fix for jupyterlab/jupyterlab#3413, explanation of the fixes is on the issue.

  • the default TERM to xterm-256color
  • only override TERM if its not previously set

* the default TERM to xterm-256color
* only override TERM if its not previously set
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073
Copy link
Contributor

I'll cut a release with this tomorrow

@blink1073 blink1073 merged commit 89425f3 into jupyter:master Sep 6, 2021
@blink1073 blink1073 added the bug label Sep 6, 2021
@rvalieris rvalieris deleted the fix-term branch September 7, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants