Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Support for Python 2 Lexing #589

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Oct 30, 2023

I don't think there is much reasons to lex Python 2 with such a recent QtConsole/IPython.

closes #588

I don't think there is much reasons to lex Python 2 with such a recent
QtConsole/IPython.

closes jupyter#588
@ccordoba12
Copy link
Collaborator

@Carreau, thanks for your help with this! The thing is we still support Python 2 kernels in Spyder and some people rely on them. So, we need to keep support for it until our next major version, to be released at the beginning of next year.

@ccordoba12 ccordoba12 added this to the 5.6.0 milestone Nov 5, 2023
@Carreau
Copy link
Member Author

Carreau commented Nov 6, 2023

Let's move that to draft to prevent merging for now.

@Carreau Carreau marked this pull request as draft November 6, 2023 09:31
@ccordoba12 ccordoba12 changed the title Remove Support for Python 2 Lexing. Remove Support for Python 2 Lexing Aug 24, 2024
@ccordoba12 ccordoba12 marked this pull request as ready for review August 24, 2024 17:29
Copy link
Collaborator

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Carreau!

@ccordoba12 ccordoba12 merged commit 7d5b907 into jupyter:main Aug 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using IPythonLexer from IPython.lib.lexers
2 participants