-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start threading Structured signature into existing datastructures. #291
Conversation
The format is compatible with the format produced by Griffe, except we don't use an ast form for the annotations.
I was thinking to just store the text form on the Signature object, or to have a method to reconstruct it if enough information is already there in the structured form. As I suggested in the issue, I think it's a good idea to still include the str form in the JSON alongside the structured form. |
Might be a good idea to merge this and #289 together to avoid conflicts. |
Yes, I was just experimenting on seeing how far I could get for simpler signature, and ended up going further than I thoughts
It's on my todo. I was not planning to go that far and tried to stay away from this file, but ended up touch it anyway. I'll try to find some time to merge the two, or split this one in smaller chunks. |
There are many objects that are called "Signature", Just a draft to try to rename the current one to "TextSignature", to differentiate, and try to pass the current one to be serialized/loaded.
There are many objects that are called "Signature", Just a draft to try to rename the current one to "TextSignature", to differentiate, and try to pass the current one to be serialized/loaded.