Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS for full windowing mode #7337

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix CSS for full windowing mode #7337

merged 1 commit into from
Apr 22, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 22, 2024

Extract part of #7321.

Fixes #7231
Closes #7301

@jtpio jtpio added the bug label Apr 22, 2024
@jtpio jtpio added this to the 7.2.0 milestone Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/fix-full-windowing-css

@jtpio jtpio marked this pull request as ready for review April 22, 2024 10:41
@jtpio
Copy link
Member Author

jtpio commented Apr 22, 2024

Moving forward with this, so there is some kind of fix available.

But the full windowing mode definitely deserves a second look so it can be enabled by default, maybe as part of #7321 or #7318.

@jtpio jtpio merged commit f6a56f5 into jupyter:main Apr 22, 2024
33 of 34 checks passed
@jtpio jtpio deleted the fix-full-windowing-css branch April 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jtpio jtpio

Labels
bug
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.

CSS issue when the Notebook windowing mode is set to full
1 participant
@jtpio