Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable add a cell button #6872

Merged
merged 3 commits into from
May 16, 2023
Merged

Enable add a cell button #6872

merged 3 commits into from
May 16, 2023

Conversation

tuncbkose
Copy link
Contributor

@tuncbkose tuncbkose commented May 16, 2023 •
edited by jtpio
Loading

Closes #6852
Fixes #6389

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch tuncbkose/notebook/add-cell

@jtpio jtpio added this to the 7.0 milestone May 16, 2023
@jtpio
Copy link
Member

jtpio commented May 16, 2023

Thanks!

Not sure why the UI test fails on Firefox only but I can have a look.

@tuncbkose
Copy link
Contributor Author

The "click to add a cell" button seems to be visible by default in the videos of failing tests. I am not immediately sure why this would be the case.

@jtpio
Copy link
Member

jtpio commented May 16, 2023

That is indeed odd. It works fine in a normal Firefox.

@jtpio
Copy link
Member

jtpio commented May 16, 2023

Rebasing onto the latest main to grab the changes from #6874 and see if they might help fix the UI tests issue.

@jtpio
Copy link
Member

jtpio commented May 16, 2023 •
edited
Loading

see if they might help fix the UI tests issue.

Looks like it doesn't. I'll be investigating this as it is reproducible when running Playwright locally.

@jtpio
Copy link
Member

jtpio commented May 16, 2023

Strangely running the Playwright tests locally with the --headed flag seems to be working fine:

image

@jtpio
Copy link
Member

jtpio commented May 16, 2023

This could be an issue between the headless and headful modes in Firefox. Linking to microsoft/playwright#4295 as a potential starting point for investigation.

@jtpio jtpio mentioned this pull request May 16, 2023
Open
@jtpio
Copy link
Member

jtpio commented May 16, 2023

Adding the workaround for Firefox helps make the tests more stable.

I opened #6876 to investigate more separately and to avoid blocking this PR.

jtpio
jtpio approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit c77ebdc into jupyter:main May 16, 2023
@tuncbkose tuncbkose deleted the add-cell branch May 17, 2023 06:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@tuncbkose tuncbkose

Labels
enhancement
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

Add the "Click to add a cell" button Double-clicking to add cells (feature parity with classic notebook v6)
2 participants
@tuncbkose @jtpio