Remove "Close Tab" menu entry #6843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @timmerk3 for looking into it. |
jtpio
reviewed
Apr 20, 2023
| @@ -13,6 +13,13 @@ | |||
| { | |||
| "command": "notebook:trust", | |||
| "rank": 20 | |||
| }, | |||
| { | |||
| "type": "submenu", | |||
There was a problem hiding this comment.
Not sure it should be submenu here, since the entry appears as a regular single entry?
Also when trying this PR on Binder the menu entry still seems to be displayed:
Merged
|
FYI @timmerk3 I pushed a small change to fix the config. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the "Close Tab" menu entry from the file dropdown, brought up in #6832. The user should be the one manually closing the tab.