Update to JupyterLab 4.0.0b1 and 4.0.0b2

[jtpio]

Update to https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0b1 and https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0b2

• Update @jupyterlab, @lumino packages
• Check Display shortcuts jupyterlab/jupyterlab#14053
• Check Show first line of cell when collapsed jupyterlab/jupyterlab#14141
• Check https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0b1
• Check https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0b2

[github-actions]

👈 Launch a Binder on branch jtpio/notebook/update-lab-beta-1

[jtpio]

Strangely the title and checkpoint indicator seem to be gone:

[jtpio]

Strangely the title and checkpoint indicator seem to be gone:

Looks like this piece of code is not hit on page reload:

notebook/packages/notebook-extension/src/index.ts

Lines 85 to 88 in f0ec5f3

	const widget = new Widget({ node });
	widget.id = DOMUtils.createDomID();
	widget.addClass('jp-NotebookCheckpoint');
	return widget;

Although the kernel logo using the same approach and shows up fine:

notebook/packages/notebook-extension/src/index.ts

Lines 180 to 182 in f0ec5f3

	const widget = new Widget({ node });
	widget.addClass('jp-NotebookKernelLogo');
	return widget;

[jtpio]

cc @fcollonval @brichet I see a few PRs related to the settings in the 4.0.0b1 changelog: https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0b1

Maybe you know if they could be related to the issue mentioned above?

[brichet]

@jtpio yes it's strange.
I don't know if this is related but I can take a look at it next week.

[brichet]

@jtpio reverting the changes you mentioned at jupyterlab/jupyterlab#14195 (comment) seems that this does not fix it.

Another thing that is strange, both widgets (title and checkpoint) are displayed if the related plugin activation do not depends on IDocumentManager.
But in both case, the plugin is activated, depending or not in IDocumentManager.
Just in case this rings a bell...

EDIT:
if I replace optional: [IToolbarWidgetRegistry], by optional: [IToolbarWidgetRegistry, IDocumentManager], in kernelLogo, the widget is not displayed either.

[jtpio]

Thanks @brichet for looking into it 👍

if I replace optional: [IToolbarWidgetRegistry], by optional: [IToolbarWidgetRegistry, IDocumentManager], in kernelLogo, the widget is not displayed either.

That's strange. At first glance I don't see why the IDocumentManager would have any effect here for toolbar items.

[brichet]

Actually, the problem comes from another part of jupyterlab/jupyterlab#14195:

https://github.com/jupyterlab/jupyterlab/blob/6d9217cc9681879dd822e6aaa5cedad2a648f99c/packages/settingregistry/src/settingregistry.ts#L394-L403

Everything works fine if I avoid this part for @jupyterlab/application-extension:top-bar plugin. And I don't know why it works if the IDocumentManager is not a dependency.

[jtpio]

Maybe it's a race condition, or the behavior is undefined depending on which plugin is activated first?

[jtpio]

Actually, the problem comes from another part of jupyterlab/jupyterlab#14195:

Maybe we should track this in a separate issue in JupyterLab so it can be fixed for the next JupyterLab beta release?

It looks like a breaking change which currently blocks the update of Notebook 7.

[jtpio]

Maybe we should track this in a separate issue in JupyterLab so it can be fixed for the next JupyterLab beta release?

I opened jupyterlab/jupyterlab#14366 to track this.

[brichet]

There is a workaround for this update, waiting for it to be fixed in the next release of JupyterLab:
jupyterlab/jupyterlab#14366 (comment)

[jtpio]

Beta 2 seems to be fixing the settings issue mentioned above 👍

Now the button to add a new cell at the end of the notebook needs to be fixed. For reference it was added in jupyterlab/jupyterlab#14109

[jtpio]

Now the button to add a new cell at the end of the notebook needs to be fixed.

Might just try to disable it for now to be able to finish this update.

[jtpio]

bot please update playwright snapshots

[jtpio]

bot please update playwright snapshots

[jtpio]

Looks like we might hit jupyterlab/jupyterlab#14385 as well.

[jtpio]

Opened #6852 to track adding back the "Click to add a cell" button. It was causing issues on CI with the reference snapshots on Firefox.