Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides 'micro' toolbars in notebook #6791

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Conversation

JasonWeill
Copy link
Collaborator

Fixes #6787 and #6784.

Hides the jp-Toolbar-micro stub toolbars in Jupyter Notebook. These are used as spacers below the JupyterLab tab bar, but this tab bar is not used in Jupyter Notebook, so they should not be visible.

Before:

image

image

After:

Note that the thin white micro-toolbar above the main widget is gone.

image

image

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch JasonWeill/notebook/terminal-toolbar

@jtpio
Copy link
Member

jtpio commented Mar 23, 2023

this tab bar is not used in Jupyter Notebook, so they should not be visible.

But they could be used by third-party extensions though. For example they could add buttons to the toolbar to refresh the terminal:

image

@JasonWeill JasonWeill added the bug label Mar 23, 2023
@jtpio jtpio added this to the 7.0 milestone Mar 23, 2023
@JasonWeill
Copy link
Collaborator Author

bot please update playwright snapshots

@jtpio
Copy link
Member

jtpio commented Mar 24, 2023

Not sure there is any snapshot for files and terminals at the moment.

@JasonWeill JasonWeill requested a review from jtpio March 27, 2023 18:57
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit b7b822a into jupyter:main Mar 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra white inner border and stub toolbar in terminal
2 participants