Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving some accessibility issues #6719

Merged
merged 6 commits into from
Feb 9, 2023
Merged

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Feb 8, 2023

This PR addresses some accessibility issues:

  • adds landmarks roles
  • removes duplicate id on running session from side panel and form main area
  • adds title on the sidebar button (a later PR will be necessary for translation)
  • avoids adding kernel logo image if not necessary, to avoid image without title

Related to #6671

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Binder 👈 Launch a Binder on branch brichet/notebook/accessibility

@jtpio jtpio added this to the 7.0 milestone Feb 8, 2023
@@ -185,7 +185,7 @@ const notebookTreeWidget: JupyterFrontEndPlugin<INotebookTree> = {

if (manager) {
const running = new RunningSessions(manager, translator);
running.id = 'jp-running-sessions';
running.id = 'jp-running-sessions-tree';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the following selector should also be updated in the UI tests:

await expect(page.locator('#main-panel #jp-running-sessions')).toBeVisible();

Copy link
Collaborator Author

@brichet brichet Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio

@@ -90,6 +90,8 @@ export class SidePanelHandler extends PanelHandler {
this.hide();
};
closeButton.className = 'jp-Button jp-SidePanel-collapse';
closeButton.title = 'Collapse side panel';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this string be translated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I was thinking doing this in a later PR, as it involves more changes.
The sidepanels are created with the NotebookShell, so (I guess) before the translator.
Currently the NotebookShell does not include a translator, so we should probably add a translator-extension that add a translator to the shell, in order to translate the title.
If you think there is a simpler way maybe we can include it in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right. Then we can indeed have a look separately and track this in an issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #6722 to track this.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 905553e into jupyter:main Feb 9, 2023
@brichet brichet deleted the accessibility branch February 10, 2023 13:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants