-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving some accessibility issues #6719
Conversation
@@ -185,7 +185,7 @@ const notebookTreeWidget: JupyterFrontEndPlugin<INotebookTree> = { | |||
|
|||
if (manager) { | |||
const running = new RunningSessions(manager, translator); | |||
running.id = 'jp-running-sessions'; | |||
running.id = 'jp-running-sessions-tree'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the following selector should also be updated in the UI tests:
notebook/ui-tests/test/tree.spec.ts
Line 43 in ce9c16a
await expect(page.locator('#main-panel #jp-running-sessions')).toBeVisible(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtpio
@@ -90,6 +90,8 @@ export class SidePanelHandler extends PanelHandler { | |||
this.hide(); | |||
}; | |||
closeButton.className = 'jp-Button jp-SidePanel-collapse'; | |||
closeButton.title = 'Collapse side panel'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this string be translated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I was thinking doing this in a later PR, as it involves more changes.
The sidepanel
s are created with the NotebookShell
, so (I guess) before the translator.
Currently the NotebookShell
does not include a translator, so we should probably add a translator-extension
that add a translator to the shell, in order to translate the title.
If you think there is a simpler way maybe we can include it in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right. Then we can indeed have a look separately and track this in an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked and JupyterLab sets the translator here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #6722 to track this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR addresses some accessibility issues:
Related to #6671