Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releaser workflows #6698

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Add releaser workflows #6698

merged 2 commits into from
Jan 17, 2023

Conversation

blink1073
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch blink1073/notebook/use-releaser-from-repo

@blink1073
Copy link
Contributor Author

I set up the appropriate permissions and tokens for the bot.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio added this to the 7.0 milestone Jan 17, 2023
@jtpio jtpio merged commit 4e6282c into jupyter:main Jan 17, 2023
@jtpio
Copy link
Member

jtpio commented Jan 19, 2023

Attempting to make a release with the new workflows and facing the following issue:


***github.com/jupyter/notebook.git
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Changes must be made through a pull request. Required status check "tests_check" is expected.

I don't know if this check is new but I will disable it for now to finish the release.

@jtpio
Copy link
Member

jtpio commented Jan 19, 2023

Strangely a release commit and a tag have been pushed to the repo:

image

But it does not appear on the main branch:

image

Which makes the Publish Release workflow fail because the tag already exists.

I'll try deleting the tag and restart the workflow.

@jtpio
Copy link
Member

jtpio commented Jan 19, 2023

Looks like it went through after disabling the branch protection rule: https://github.com/jupyter/notebook/releases/tag/v7.0.0a11

For more information the workflow runs are available here: https://github.com/jupyter/notebook/actions/workflows/publish-release.yml

@blink1073
Copy link
Contributor Author

I adjusted the permissions of the bot account and reinstated the branch protection rules.

@blink1073 blink1073 deleted the use-releaser-from-repo branch January 19, 2023 15:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants