Ensure custom preload is correctly handled #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
close/reopen to kick CI |
|
LGTM, thank you @echarles! |
This was referenced Oct 19, 2022
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 28, 2022
https://build.opensuse.org/request/show/1031574 by user bnavigator + dimstar_suse - Add notebook-pr6578+pr6580-404errors.patch * fix 404 errors at startup * gh#jupyter/notebook#6580 -- custom preload * gh#jupyter/notebook#6578 -- jquery from nbclassic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of jupyter/nbclassic#155
The custom preload needs to be handled in
page.htmlandbuild-main.js.We also bump and pin to
nbclassic==0.4.6.