-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum version of jQuery to 3.6.0 #6471
Conversation
Tagging @RRosio as suggested by jweill-aws. |
Closing / Reopening to retrigger CI. |
Looks like only 3 CI jobs have run. Is this expected? |
@dylanramzn I think the CI was previously run on Travis which has probably been desactived. Do you think that you could backport the GitHub actions used in the 6.5.x branch ? https://github.com/jupyter/notebook/tree/6.5.x/.github/workflows |
We have discussed this at the last community call with @jweill-aws. There has been a consensus to merge an release without a running CI, assuming the minimal sanity checks are done on a local env. This exceptional procedure is applied based on the nature of the change (jQuery front-end dependency upgrade being used all over the world). I have tested locally this branch and as a user it works fine. I have also run the pytest command which returns
@dylanramzn BTW the latest jquery version is 3.6.0 and you are using here 3.5.0. Any reason for that? |
@dylanramzn Another thing to add is that pinning the dependency, jinja2 to a version <= 3.0.0 is necessary, as the more recent versions of jinja2 package cause import errors. I've verified this with a clean environment and a source package install which currently installs the most recent jinja2 version 3.1.2 Current Output with Jinja2==3.1.2500: Internal Server Error [E 08:04:41.149 NotebookApp] Uncaught exception GET /notebooks/getting-familiar-jnb.ipynb (::1) HTTPServerRequest(protocol='http', host='localhost:8888', method='GET', uri='/notebooks/getting-familiar-jnb.ipynb', version='HTTP/1.1', remote_ip='::1') Traceback (most recent call last): File "/Users/rosioreyes/miniconda3/envs/check_jQuery/lib/python3.8/site-packages/tornado/web.py", line 1711, in _execute result = method(*self.path_args, **self.path_kwargs) File "/Users/rosioreyes/miniconda3/envs/check_jQuery/lib/python3.8/site-packages/tornado/web.py", line 3208, in wrapper return method(self, *args, **kwargs) File "/Users/rosioreyes/Desktop/code/jupyter/notebook5/notebook/notebook/notebook/handlers.py", line 90, in get self.write(self.render_template('notebook.html', File "/Users/rosioreyes/Desktop/code/jupyter/notebook5/notebook/notebook/base/handlers.py", line 519, in render_template return template.render(**ns) File "/Users/rosioreyes/miniconda3/envs/check_jQuery/lib/python3.8/site-packages/jinja2/environment.py", line 1301, in render self.environment.handle_exception() File "/Users/rosioreyes/miniconda3/envs/check_jQuery/lib/python3.8/site-packages/jinja2/environment.py", line 936, in handle_exception raise rewrite_traceback_stack(source=source) File "/Users/rosioreyes/Desktop/code/jupyter/notebook5/notebook/notebook/templates/notebook.html", line 1, in top-level template code {% extends "page.html" %} File "/Users/rosioreyes/Desktop/code/jupyter/notebook5/notebook/notebook/templates/page.html", line 154, in top-level template code {% block header %} File "/Users/rosioreyes/Desktop/code/jupyter/notebook5/notebook/notebook/templates/notebook.html", line 112, in block 'header' {% for exporter in get_frontend_exporters() %} File "/Users/rosioreyes/Desktop/code/jupyter/notebook5/notebook/notebook/notebook/handlers.py", line 19, in get_frontend_exporters from nbconvert.exporters.base import get_export_names, get_exporter File "/Users/rosioreyes/miniconda3/envs/check_jQuery/lib/python3.8/site-packages/nbconvert/__init__.py", line 4, in from .exporters import * File "/Users/rosioreyes/miniconda3/envs/check_jQuery/lib/python3.8/site-packages/nbconvert/exporters/__init__.py", line 3, in from .html import HTMLExporter File "/Users/rosioreyes/miniconda3/envs/check_jQuery/lib/python3.8/site-packages/nbconvert/exporters/html.py", line 12, in from jinja2 import contextfilter ImportError: cannot import name 'contextfilter' from 'jinja2' (/Users/rosioreyes/miniconda3/envs/check_jQuery/lib/python3.8/site-packages/jinja2/__init__.py) |
Also pin jinja2<=3.0.0 to fix errors opening notebooks
This PR was originally just a back port of the commit made previously for Notebook 6. #5491 @RRosio I changed it to jQuery 3.6.0, and pinned jinja2 to <=3.0.0. I ran a sanity test and verified I can open a notebook and execute |
This PR looks good so I will go ahead and merge! |
Resolves #6469