Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating version to show dev #6421

Merged
merged 1 commit into from
May 14, 2022
Merged

updating version to show dev #6421

merged 1 commit into from
May 14, 2022

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented May 12, 2022

No description provided.

@RRosio
Copy link
Collaborator Author

RRosio commented May 13, 2022

Hi Steven @blink1073, Eric Charles @echarles mentioned that I could ask you about this PR. He let me know that this update to the version may cause issues with the Github releaser, and that this branch would ideally be cut off here before the next release of notebook 6.5.x, I believe. In that case would it be best to simply close this PR?

@blink1073
Copy link
Contributor

blink1073 commented May 14, 2022

Hi @RRosio, this should be fine to go in as-is. Worst case the next feature in releaser doesn't work and you have to manually specify the new version.

@echarles
Copy link
Member

Thx @RRosio and @blink1073. I will merge this one.

@echarles echarles merged commit 920c5cc into jupyter:6.4.x May 14, 2022
@RRosio RRosio deleted the update-version branch July 25, 2022 19:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants