Remove blank space at the bottom of the notebook #6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @HaudinFlorence maybe this will fix the issue you noticed when embedding a notebook in a documentation site with JupyterLite? |
|
Merging as this improves the look and feel of the notebook document. Happy to iterate more on it based on feedback. This could also be made a setting if folks prefer the blank space like in JupyterLab. |
This was referenced Apr 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a lower
min-heightfor the::afterelement at the bottom of the notebook.Before
The notebook would take the full page height, and sometimes add a scrollbar:
After
This is closer to the Notebook v6 look and feel: