-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary workaround to fix js-tests related to sanitizer js loading by phantomjs #6356
Temporary workaround to fix js-tests related to sanitizer js loading by phantomjs #6356
Conversation
Close/open to trigger CI. |
Some python tests are now failing with @blink1073 Could it be a side-effect of yesterday #6260 I guess the CI checks has run on January. Not sure if some (transitive) deps have changed since then. |
@blink1073 The goal of this PR is reached. It solves the casperjs issue. The The service and notebook js tests have failures, but a lot of them pass. The goal is to fix them in subsequent PRs. I don't think the python failures are related to the changes of this PR.
|
#6357 fixes the python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thx @blink1073 |
Follow up of #6354