Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fix): make tests run with nbconvert >=6,<7 #5092

Conversation

maartenbreddels
Copy link
Contributor

@maartenbreddels
Copy link
Contributor Author

PS: It seems that only the tests were affected.

@takluyver
Copy link
Member

Adding a specific 'except for nbconvert' workaround doesn't seem like the right fix for the long term.

Maybe rather than patching out the entire of jupyter_path() to temporary directories, we should be patching out the user and system directories, and leaving ENV_JUPYTER_PATH alone, so it can access files installed along with the importable Python packages.

That would mean that the tests can still be isolated by using an environment system, but they don't try to isolate themselves from data files in the environment.

@maartenbreddels
Copy link
Contributor Author

@takluyver I agree, that makes more sense.

@takluyver
Copy link
Member

#5111 is my attempt at that.

@takluyver takluyver closed this in e53383c Dec 14, 2019
@takluyver
Copy link
Member

Thanks - closing this one as I've merged #5111.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tests with nbconvert 6
2 participants