Don't trash files on different device to home dir on Linux #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've asked on send2trash about having a more specific exception type that we could catch: arsenetar/send2trash#20 |
ghost
mentioned this pull request
| # files on the same partition as the home directory. | ||
| file_dev = os.stat(os_path).st_dev | ||
| home_dev = os.stat(os.path.expanduser('~')).st_dev | ||
| return file_dev == home_dev |
There was a problem hiding this comment.
Unfortunately, this test doesn't do what you'd hope on GPFS (under Linux). If the directories are part of different filesets, you'll still get an EXDEV if you try to rename a file/dir from one to the other.
stefanor
added a commit
to stefanor/notebook
that referenced
this pull request
Dec 1, 2020
_check_trash() was added (in jupyter#3304) because TrashPermissionError didn't exist, yet. Now that it does, we can use it, and stop guessing what will cause a permission problem. Closes: jupyter#3374
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a crude check, but I imagine that most users will be working either in their home directory, or on the same device, so it's not worth trying to do a more complex check. I'm going to ask for better exceptions from send2trash so we can distinguish these cases from others.
Closes gh-3249