ES6 and prerequisite to shortcut editor #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| define([ | |||
| 'base/js/utils', | |||
| 'base/js/keyboard', | |||
| 'base/js/keyboard' | |||
There was a problem hiding this comment.
Stripping trailing commas makes me a little sad. Just curious: what brought this on?
There was a problem hiding this comment.
Sorry, tried enabling eslint and my editor complains. I can deactivate and revert that.
|
Fixed. |
minrk
changed the title
|
Yeah ! Thanks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason casper seem to be unhappy when I actually introduce es6 things in modules,
so this is a subset of #1347 where tests are (or at least should be) passing on travis.