-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotted line of the ruler extension intersects the letters #2869
Comments
Have you reported this to the ruler extension developer? |
@jcb91 - I think you're the right person to consider this? |
@axil I'll do 😉. From your extensive detective work detailed on codemirror/codemirror5#4042, and as you suggest, CodeMirror dev seems to think that jupyter is not using CodeMirror's expected/required padding arrangement, which separates horizontal and vertical padding into separate elements. Since the nbextension doesn't add any CSS, it isn't the cause, and it would make sense to fix it in notebook here. I could presumably add CSS overrides to the extension as a temporary hotfix though... |
@jcb91 I would be happy with any solution that works and would be 'official'. As for myself I can make a hotfix in a couple of ways but I declared to my students that any decent editor has this feature (ruler) and the next day I found out that in jupyter (which is one of the editors that we use) this feature is currently hardly usable. I wouldn't like to advise them to make a manual patch in a python lib. :) |
🤣 Ok, well, the best way seems like a PR to notebook, I guess, but equally, you can slap one onto ipython-contrib/jupyter_contrib_nbextensions, which may get a patch release sooner... |
@jcb91 If that emoji meant irony, here's a list of python editors which support vertical guidelines: |
@axil apologies, reading that back, it wasn't very clear what I meant, but I very much agree that having a ruler is a basic feature of any decent editor. The intention was to convey laughter at the absurdity of not having a functioning ruler, but yeah, I should have used some actual words, rather than just an ambiguous face! I'll have a stab at an override for the extension now... |
see jupyter/notebook#2869 for details
ok, PRs for notebook & nbextension submitted... |
Notebook 5.2.0rc1 is available on PyPI so please give it a try and confirm that this is resolved 👍:
|
Yes, working as expected! That was fast! Thanks! |
The latest notebook version that works correctly is 4.2.3:
I traced back the issue to the questionable codemirror bugfix codemirror/codemirror5#4042
I also provided a patch there.
But codemirror author believes that that the issue is on the jupyter side and suggests a solution there.
The text was updated successfully, but these errors were encountered: