Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotted line of the ruler extension intersects the letters #2869

Closed
axil opened this issue Sep 27, 2017 · 10 comments · Fixed by #2880
Closed

Dotted line of the ruler extension intersects the letters #2869

axil opened this issue Sep 27, 2017 · 10 comments · Fixed by #2880

Comments

@axil
Copy link

axil commented Sep 27, 2017

image
The latest notebook version that works correctly is 4.2.3:
image
I traced back the issue to the questionable codemirror bugfix codemirror/codemirror5#4042

I also provided a patch there.

But codemirror author believes that that the issue is on the jupyter side and suggests a solution there.

@rgbkrk
Copy link
Member

rgbkrk commented Sep 27, 2017

Have you reported this to the ruler extension developer?

@axil
Copy link
Author

axil commented Sep 27, 2017

@jcb91 - I think you're the right person to consider this?

@jcb91
Copy link
Contributor

jcb91 commented Sep 27, 2017

@axil I'll do 😉. From your extensive detective work detailed on codemirror/codemirror5#4042, and as you suggest, CodeMirror dev seems to think that jupyter is not using CodeMirror's expected/required padding arrangement, which separates horizontal and vertical padding into separate elements. Since the nbextension doesn't add any CSS, it isn't the cause, and it would make sense to fix it in notebook here. I could presumably add CSS overrides to the extension as a temporary hotfix though...

@axil
Copy link
Author

axil commented Sep 27, 2017

@jcb91 I would be happy with any solution that works and would be 'official'. As for myself I can make a hotfix in a couple of ways but I declared to my students that any decent editor has this feature (ruler) and the next day I found out that in jupyter (which is one of the editors that we use) this feature is currently hardly usable. I wouldn't like to advise them to make a manual patch in a python lib. :)

@jcb91
Copy link
Contributor

jcb91 commented Sep 28, 2017

I declared to my students that any decent editor has this feature

🤣

Ok, well, the best way seems like a PR to notebook, I guess, but equally, you can slap one onto ipython-contrib/jupyter_contrib_nbextensions, which may get a patch release sooner...

@axil
Copy link
Author

axil commented Sep 29, 2017

@jcb91 If that emoji meant irony, here's a list of python editors which support vertical guidelines:
spyder, pycharm, sublime, eclipse, vim, emacs, visual studio, mechanical typewriter, etc

@jcb91
Copy link
Contributor

jcb91 commented Sep 29, 2017

@axil apologies, reading that back, it wasn't very clear what I meant, but I very much agree that having a ruler is a basic feature of any decent editor. The intention was to convey laughter at the absurdity of not having a functioning ruler, but yeah, I should have used some actual words, rather than just an ambiguous face! I'll have a stab at an override for the extension now...

jcb91 added a commit to jcb91/jupyter_contrib_nbextensions that referenced this issue Sep 30, 2017
jcb91 added a commit to jcb91/notebook that referenced this issue Sep 30, 2017
@jcb91
Copy link
Contributor

jcb91 commented Sep 30, 2017

ok, PRs for notebook & nbextension submitted...

@gnestor
Copy link
Contributor

gnestor commented Oct 9, 2017

Notebook 5.2.0rc1 is available on PyPI so please give it a try and confirm that this is resolved 👍:

pip install notebook --pre --upgrade

@axil
Copy link
Author

axil commented Oct 10, 2017

Yes, working as expected! That was fast! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants