Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination not used when installing nbextensions #1384

Closed
jhamrick opened this issue Apr 21, 2016 · 1 comment · Fixed by #1391
Closed

Destination not used when installing nbextensions #1384

jhamrick opened this issue Apr 21, 2016 · 1 comment · Fixed by #1391
Labels
status:resolved-locked
Milestone
4.2.1

Comments

@jhamrick
Copy link
Member

The destination variable isn't used when installing nbextensions, even though the install_nbextension function supports it, and it's defined in the InstallNBExtensionApp class:

https://github.com/jupyter/notebook/blob/master/notebook/nbextensions.py#L703

It looks like it was removed in #879 here:

https://github.com/jupyter/notebook/pull/879/files#diff-720744abca8751e2ff12988ac308c604L308
@minrk minrk added this to the 4.2.1 milestone Apr 26, 2016
@minrk minrk mentioned this issue Apr 26, 2016
Merged
@minrk
Copy link
Member

minrk commented Apr 26, 2016

Fixed by #1391

minrk added a commit to minrk/notebook that referenced this issue Jun 1, 2016
@minrk
Backport PR jupyter#1391: specify destination for nbextension install
27eea4b 
arg was supported, just not passed along

closes jupyter#1384
minrk added a commit that referenced this issue Jun 3, 2016
@minrk
Backport PR #1391: specify destination for nbextension install
e075309 
arg was supported, just not passed along

closes #1384
yuvipanda pushed a commit to yuvipanda/notebook that referenced this issue Jul 26, 2016
@minrk @yuvipanda
Backport PR jupyter#1391: specify destination for nbextension install
0b727ce 
arg was supported, just not passed along

closes jupyter#1384
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
4.2.1
Development

Successfully merging a pull request may close this issue.

specify destination for nbextension install minrk/notebook
2 participants
@jhamrick @minrk