ReadTheDocs not rendering notebook after a recent PR

[willingc]

@takluyver Would you mind checking if it is rendering on your system?

[willingc]

Checking if PR #1266 or #1304 introduced a new issue.

[willingc]

Looks like the CSS changes (two commits: b3788c2 and 9c56f45) in #1266 is the cause of RTD to display as above. The commits build fine locally and pass as green on RTD yet the rendering is incorrect. I will modify if I can in a new PR within an hour; otherwise, I will revert #1266

[willingc]

@mgeier I'm not sure why the custom CSS did not render properly on RTD. Thanks for your work on PR #1266. I only backed out the code that was giving RTD trouble.

[mgeier]

I suspect that this is actually a RTD bug: readthedocs/readthedocs.org#2116.

[willingc]

@mgeier I agree. Thanks for filing the issue on RTD. 🍰

[mgeier]

@willingc There was a response at readthedocs/readthedocs.org#2116, but I don't like the proposed solution (because it is IMHO a work-around and no real solution).
I also asked at Sphinx: sphinx-doc/sphinx#2442

Any opinions on that?

[mgeier]

@willingc Did you have an opportunity to look into this?

I could really need somebody to support me on readthedocs/readthedocs.org#2116!

[mgeier]

@willingc FYI: the problem solved itself because I included the CSS fixes directly into nbsphinx.

I still think the original problem is a bug in RTD and Sphinx ...

[willingc]

@mgeier Thanks for the update. I will see some of the RTD folks in 2 weeks. I'll see if I can have them look at in person.

[mgeier]

@willingc Did you have a chance to talk to the RTD people?
I don't know what to answer to readthedocs/readthedocs.org#2116 (comment), I think I've already said everything ...

Currently, I'm discussing this on a Sphinx issue, see sphinx-doc/sphinx#2442 (comment).

It would really be nice to get your opinion on this (be it for or against my statements).

[willingc]

@mgeier Traveling today. Just left some comments here: sphinx-doc/sphinx#2442 (comment)