Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank tab names and labextension button label #1756

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

tuncbkose
Copy link
Contributor

@tuncbkose tuncbkose commented Mar 21, 2023

Fixes #1722 and changes "fetch" to "Fetch" in lab assignment-list, to be more consistent with the rest of the buttons.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch AaltoSciComp/nbgrader/tabfix

@tuncbkose tuncbkose changed the title Fix blank tab names Fix blank tab names and labextension button label Mar 22, 2023
@brichet
Copy link
Contributor

brichet commented Jun 12, 2023

Thanks @tuncbkose, the failing test is not related.

@brichet brichet merged commit c730a7c into jupyter:main Jun 12, 2023
@tuncbkose tuncbkose deleted the tabfix branch June 13, 2023 06:27
brichet added a commit to brichet/nbgrader that referenced this pull request Jun 15, 2023
brichet added a commit to brichet/nbgrader that referenced this pull request Jun 15, 2023
brichet added a commit to brichet/nbgrader that referenced this pull request Jun 15, 2023
brichet added a commit to brichet/nbgrader that referenced this pull request Jun 15, 2023
brichet added a commit to brichet/nbgrader that referenced this pull request Jun 16, 2023
brichet added a commit to brichet/nbgrader that referenced this pull request Jun 16, 2023
jtpio pushed a commit that referenced this pull request Jul 18, 2023
* Update dependencies to jupyterlab>=4, fix menu entries and fix mathjax error

* Includes assignment-list, course-list and formgrader extensions as main panel tab

* Remove required dependency to LabShell

* Make it work with Notebook7 and JupyterLab4

* update dependencies

* Refactore create_assignment_extension to depend on CellModel instead of Cell widget, and to simplify the listeners

* Update the tests according to the updates of JupyterLab

* Reintegrate the cellPrompt in create assignment cell widget

* Activate by default the new created tab in Notebook (assignment list, course list and formgrader)

* add test for extensions in notebook

* Fix docs tests and insert nbextensions test in UI-tests

* Update dependencies to jupyterlab-4.0.0a32 and notebook-7.0.0a10

* Downgrade dependency to Notebook as it breaks installation

* bump to Notebook-7.0.0a10

* update dependencies

* Refactor the extensions for a better managment of the menu and palettecommand in Notebook

* Update to Jlab 4.0.0a34 and Notebook 7.0.0a13

* Open the existing Formgrader tab if already loaded from courses list tab

* fix UI tests

* Removal of python 3.7 support and integration of python 3.11 in tests

* Update actions and node version in tests

* Update to jupyterlab 4.0.0a37 and notebook 7.0.0a17

* Fix before-build-npm

* Includes #1756

* Remove nbextensions and related code

* Update dependencies to lab 4 released and notebook 7b.4

* Add the playwright report as artifact
AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
* Update dependencies to jupyterlab>=4, fix menu entries and fix mathjax error

* Includes assignment-list, course-list and formgrader extensions as main panel tab

* Remove required dependency to LabShell

* Make it work with Notebook7 and JupyterLab4

* update dependencies

* Refactore create_assignment_extension to depend on CellModel instead of Cell widget, and to simplify the listeners

* Update the tests according to the updates of JupyterLab

* Reintegrate the cellPrompt in create assignment cell widget

* Activate by default the new created tab in Notebook (assignment list, course list and formgrader)

* add test for extensions in notebook

* Fix docs tests and insert nbextensions test in UI-tests

* Update dependencies to jupyterlab-4.0.0a32 and notebook-7.0.0a10

* Downgrade dependency to Notebook as it breaks installation

* bump to Notebook-7.0.0a10

* update dependencies

* Refactor the extensions for a better managment of the menu and palettecommand in Notebook

* Update to Jlab 4.0.0a34 and Notebook 7.0.0a13

* Open the existing Formgrader tab if already loaded from courses list tab

* fix UI tests

* Removal of python 3.7 support and integration of python 3.11 in tests

* Update actions and node version in tests

* Update to jupyterlab 4.0.0a37 and notebook 7.0.0a17

* Fix before-build-npm

* Includes jupyter#1756

* Remove nbextensions and related code

* Update dependencies to lab 4 released and notebook 7b.4

* Add the playwright report as artifact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widgets tabs are blank when opening a second time
2 participants