-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using cell ID in diffing and merging #639
Commits on Oct 27, 2023
-
An object that encapsulates differs and predicates, and also the new "is_atomic", which is added so that we can mark e.g. cell IDs as atomic. DiffConfig could potentially also be used in the future to better config notebook ignores etc?
Configuration menu - View commit details
-
Copy full SHA for 7eb83fb - Browse repository at this point
Copy the full SHA 7eb83fbView commit details -
When comparing identical sources we can avoid a full diff by a quick equality check.
Configuration menu - View commit details
-
Copy full SHA for 028b618 - Browse repository at this point
Copy the full SHA 028b618View commit details -
Avoid recursing for string mimetypes that are identical
Configuration menu - View commit details
-
Copy full SHA for 89dfb23 - Browse repository at this point
Copy the full SHA 89dfb23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 496df57 - Browse repository at this point
Copy the full SHA 496df57View commit details -
Add ID check in cell comparison
In the strictest check, cells without ID is never considered equal to cells with IDs, but they can be in the two less-strict comparisons. I.e. if a notebook ends up with only some cells having IDs, and then IDs are added to those cells later, then in the first pass the existing cells that all had IDs are first matched to each other, and only in the next passes are the cells that gained IDs compared with their old ID-less versions.
Configuration menu - View commit details
-
Copy full SHA for 4f71a5f - Browse repository at this point
Copy the full SHA 4f71a5fView commit details -
Always use line based diffing for source.
Configuration menu - View commit details
-
Copy full SHA for 1b318e6 - Browse repository at this point
Copy the full SHA 1b318e6View commit details -
Enable previously not working test
Configuration menu - View commit details
-
Copy full SHA for 17caf86 - Browse repository at this point
Copy the full SHA 17caf86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7adf55c - Browse repository at this point
Copy the full SHA 7adf55cView commit details -
This allows union strategy to correctly be applied. We might want to consider to silently ignore the strategy for dicts instead of raising, but it is hard to decide the best course without any good cases to consider.
Configuration menu - View commit details
-
Copy full SHA for a2fe203 - Browse repository at this point
Copy the full SHA a2fe203View commit details -
With union strategy, this test can pass. It is probably correct for it to fail without the explicit strategy marked.
Configuration menu - View commit details
-
Copy full SHA for f3484e9 - Browse repository at this point
Copy the full SHA f3484e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28936ff - Browse repository at this point
Copy the full SHA 28936ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0de0827 - Browse repository at this point
Copy the full SHA 0de0827View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17c105a - Browse repository at this point
Copy the full SHA 17c105aView commit details -
Only show it if `details` flag is set, and display it like any other field.
Configuration menu - View commit details
-
Copy full SHA for f21c125 - Browse repository at this point
Copy the full SHA f21c125View commit details -
Configuration menu - View commit details
-
Copy full SHA for b00f951 - Browse repository at this point
Copy the full SHA b00f951View commit details -
Configuration menu - View commit details
-
Copy full SHA for e530d81 - Browse repository at this point
Copy the full SHA e530d81View commit details -
Change the logic of cell ID comparison
Now, we use cell IDs as the highest ranking comparison, and any cells that map equal will take priority in computing snakes of matching cells. Any further comparisons (strict, moderate, approximate) will be as before, but with the implication that the cells being compared do not have an ID match on the other side, so considering ID has no meaning.
Configuration menu - View commit details
-
Copy full SHA for 29cb8ef - Browse repository at this point
Copy the full SHA 29cb8efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b57f97 - Browse repository at this point
Copy the full SHA 7b57f97View commit details -
Remove some skips that are no longer needed, fix tests that were marked xfail due to not being completed, and split some tests that had some hard-coded logical branches (`if 0:`) - fixing the previously disabled branch.
Configuration menu - View commit details
-
Copy full SHA for a2ff4fe - Browse repository at this point
Copy the full SHA a2ff4feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7973968 - Browse repository at this point
Copy the full SHA 7973968View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7baf832 - Browse repository at this point
Copy the full SHA 7baf832View commit details -
Configuration menu - View commit details
-
Copy full SHA for 591548f - Browse repository at this point
Copy the full SHA 591548fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc6d5d7 - Browse repository at this point
Copy the full SHA dc6d5d7View commit details -
Add capability to output merge decisions to file
Good for collecting debug data on merge decisions.
Configuration menu - View commit details
-
Copy full SHA for 51b0571 - Browse repository at this point
Copy the full SHA 51b0571View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70670f7 - Browse repository at this point
Copy the full SHA 70670f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6b7b65 - Browse repository at this point
Copy the full SHA a6b7b65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15e6be4 - Browse repository at this point
Copy the full SHA 15e6be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37e2fb2 - Browse repository at this point
Copy the full SHA 37e2fb2View commit details
Commits on Oct 30, 2023
-
Update tests with new behavior
Adds tests for the recently added ability to output merge decisions as raw JSON. As the tests indicate, this is a breaking behavior, but this is a major version release, so should be ok.
Configuration menu - View commit details
-
Copy full SHA for 9630642 - Browse repository at this point
Copy the full SHA 9630642View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc0be95 - Browse repository at this point
Copy the full SHA cc0be95View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8e2dff - Browse repository at this point
Copy the full SHA e8e2dffView commit details
Commits on Nov 1, 2023
-
Remove ID conflict for UI test merge_test1
This is needed to have download test work (assumes no conflicts).
Configuration menu - View commit details
-
Copy full SHA for e247fea - Browse repository at this point
Copy the full SHA e247feaView commit details -
Configuration menu - View commit details
-
Copy full SHA for efbcdff - Browse repository at this point
Copy the full SHA efbcdffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08636b8 - Browse repository at this point
Copy the full SHA 08636b8View commit details -
Fix mergeview gutter click buttons
Click should only register as final after mouse up with primary button.
Configuration menu - View commit details
-
Copy full SHA for 9884381 - Browse repository at this point
Copy the full SHA 9884381View commit details