Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the jupyter server base.handlers import #187

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Fix the jupyter server base.handlers import #187

merged 1 commit into from
Nov 29, 2022

Conversation

echarles
Copy link
Member

Fixes #185

ericsnekbytes
ericsnekbytes approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@ericsnekbytes ericsnekbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks/runs good to me.

@echarles echarles merged commit 99cb347 into jupyter:main Nov 29, 2022
@echarles echarles mentioned this pull request Dec 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnekbytes ericsnekbytes ericsnekbytes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest notebook 7 alpha uses jupyter_server 2 and breaks the shim
2 participants
@echarles @ericsnekbytes