Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop looking in the old IPython directory for nbextensions #153

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Stop looking in the old IPython directory for nbextensions #153

merged 1 commit into from
Sep 26, 2022

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 26, 2022

Looking in this path has been deprecated since 2015.

@echarles echarles added the enhancement New feature or request label Sep 26, 2022
@echarles
Copy link
Member

@minrk Do extensions like nbgrader or rise continue working removing that block code?(they are working on last nbclassic release)

@minrk
Copy link
Member Author

minrk commented Sep 26, 2022

Yes, the nbextensions directory is ~/.jupyter/nbextensions since the Jupyter split in 2014/2015. This bit of code is from when everything was in ~/.ipython before we picked the name Jupyter, to give folks time to update. It's been deprecated since before the first release of the notebook package in 2015.

echarles
echarles approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @minrk

@echarles echarles merged commit 04aaebf into jupyter:main Sep 26, 2022
@minrk minrk deleted the rm-old-ipython-nbextensions branch September 26, 2022 11:49
@jtpio jtpio mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minrk @echarles