Updating JS Dependencies #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx @RRosio for starting this. I see various failures on the CI. Just wanted to checkpoint with you to confirm (or not) that this branch is running fine on your local env. If that is the case, there maybe a root cause to all those CI failures we should look at? |
|
Hi @echarles, yes locally these changes still allow a successful install and work normally. I am taking a look through the errors since all of the CI tests fail to find one of the files associated with the jQuery package although I updated the file path in the templates, I realized I missed updating the path to jQuery in tools/build-main.js. I just pushed those updates and if that was not the problem maybe it would be best to look at the CI tests |
echarles
approved these changes
Sep 17, 2022
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.