Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlers under nbclassic if notebook 7 is found #141

Merged
merged 10 commits into from
Aug 30, 2022

Conversation

echarles
Copy link
Member

@echarles echarles commented Aug 16, 2022

The goal of this PR is to allow both Notebook 7 as NbClassic to coexist in harmony and use the /tree, /notebook... in a wise way

If Notebook 7 if found being installed, NbClassic will register his handlers under a sub URL path /nbclassic. The default URL for nbclassic will be /nbclassic/tree, so if the user launches with jupyter nbclassic, the browser will be opened by default under /nbclassic/tree. And if the user launches with jupyter notebook, the browser will be opened by default under /tree and the user will see the Notebook 7 interface.

In case of presence of Notebook 7, the NbClassic (notebook < 7) extensions will continue working (tested with RISE and nbgrader). Some edge case may exist for extensions that would explicitely make a HTTP request to a hardcoded URL, but those extensions should not do that and should be updated to another mecansim.

@echarles echarles marked this pull request as ready for review August 23, 2022 07:55
@echarles echarles changed the title Handlers under nbclassic if notebookv7 is found + rename notebook strings to nbclassic Handlers under nbclassic if notebookv7 is found Aug 23, 2022
@echarles echarles changed the title Handlers under nbclassic if notebookv7 is found Handlers under nbclassic if notebook 7 is found Aug 27, 2022
@echarles
Copy link
Member Author

This is ready for review. Please use "merge squash" if you approve it.

@RRosio
Copy link
Collaborator

RRosio commented Aug 30, 2022

This looks great! Thank you @echarles!

@RRosio RRosio merged commit 7752bd8 into jupyter:main Aug 30, 2022
@jtpio
Copy link
Member

jtpio commented Sep 27, 2022

Thanks both for working on this.

Any plans on making a new 0.4.4 release with this change, so it could be tested with the latest Notebook 7 pre-release?

@echarles
Copy link
Member Author

Any plans on making a new 0.4.4 release with this change, so it could be tested with the latest Notebook 7 pre-release?

Yes, I have already added the need for nbclassic 0.4.4 to ship the latest commits. That will be useful also for notebook 6.5.0 final. Do you have a timeline in mind?

@jtpio
Copy link
Member

jtpio commented Sep 27, 2022

Do you have a timeline in mind?

No concrete timeline, it's just so we can start testing having lab, notebook and nbclassic installed together again: jupyter/notebook#6547

@echarles
Copy link
Member Author

No concrete timeline, it's just so we can start testing having lab, notebook and nbclassic installed together again: jupyter/notebook#6547

@jtpio nbclassic 0.4.4. is just released.

@jtpio
Copy link
Member

jtpio commented Sep 29, 2022

Thanks, I just opened jupyter/notebook#6548 to see if that fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants