Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point nbclassic at the classic jupyter_notebook_config path #137

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Point nbclassic at the classic jupyter_notebook_config path #137

merged 1 commit into from
Aug 6, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Aug 5, 2022

Fixes #136

@Zsailer Zsailer added the bug Something isn't working label Aug 5, 2022
@Zsailer Zsailer mentioned this pull request Aug 5, 2022
Closed
echarles
echarles approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test and works as expected. Thx @Zsailer

@echarles echarles merged commit 33f5cbd into jupyter:main Aug 6, 2022
@Zsailer Zsailer mentioned this pull request Aug 8, 2022
Closed
@ejm714 ejm714 mentioned this pull request Aug 9, 2022
Open
@echarles echarles mentioned this pull request Aug 13, 2022
Closed
@jtpio jtpio mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jupter_notebook_config.py not being executed
2 participants
@Zsailer @echarles