Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving jsonutil tests #929

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Conversation

andrehora
Copy link
Contributor

This PR improves the tests of jsonutil.py. It adds tests to parse_date and extract_dates by covering some untested cases. Coverage has also slightly increased.

Overall, I created 5 tests to cover some common and boundary cases:

  • test_parse_date_invalid
  • test_parse_date_valid
  • test_parse_date_from_naive
  • test_extract_dates_from_str
  • test_extract_dates_from_dict

Also, the test test_extract_dates was renamed to test_extract_dates_from_list.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@blink1073 blink1073 enabled auto-merge (squash) February 8, 2023 18:10
@blink1073 blink1073 merged commit 557530b into jupyter:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants