Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ready promise and session send #852

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fix ready promise and session send #852

merged 2 commits into from
Oct 11, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Oct 11, 2022 •
edited
Loading

  • Preserves previous use of ready promises, but preserves the promise created in the constructor for initial use.
  • Backports a fix from Remove nest-asyncio dependency #835 to handle asyncio sockets in Session.send

@blink1073 blink1073 added the bug label Oct 11, 2022
@Zsailer
Copy link
Member

Zsailer commented Oct 11, 2022

Looks good, thanks!

@blink1073 blink1073 mentioned this pull request Oct 11, 2022
Closed
@blink1073 blink1073 merged commit 0a45cc4 into jupyter:7.x Oct 11, 2022
@blink1073 blink1073 deleted the fix-pending-kernels-7.x-simplified branch October 11, 2022 21:17
@blink1073 blink1073 mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zsailer Zsailer Zsailer approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @Zsailer