Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #822 in order to help fix jupyterlab/jupyterlab#11934.
Adds a decorator to classes that uses
run_sync
, so that it will attempt to patch innest_asyncio
before the methods gets called. This is done in the naive belief that the time of some of the__init__
calls are more likely to be closer to the init of the loop. It also only applies the patch if a sync class is actually instantiated, and has minimal overhead for async classes.A rather blunt instrument, but also rather hard to solve generically without putting weird restrictions on consumers of jupyter-client. The other alternative is to have
jupyter_server
always importnest_asyncio
and call the patch, even ifrun_sync
is never called.