Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Changelog Entry for 7.0.0 on master #680

Merged

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Aug 16, 2021

closes #642

@blink1073 blink1073 added this to the 7.0 milestone Aug 16, 2021
@blink1073
Copy link
Contributor Author

cc @davidbrochart @kevin-bates for approval, then I'll cut the release

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kevin-bates
Copy link
Member

@blink1073 - Thanks for putting this together and driving this process! This looks good.

I believe the specifics of the method signature changes are only documented in this comment as I wasn't sure how they'd be officially coordinated.

Does this discussion about adding a message-based interrupt into KernelClient warrant a delay? ipython/ipykernel#741 (comment)

Steven Silvester and others added 2 commits August 16, 2021 14:30
Co-authored-by: David Brochart <[email protected]>
Co-authored-by: David Brochart <[email protected]>
@blink1073
Copy link
Contributor Author

I believe the specifics of the method signature changes are only documented in this comment as I wasn't sure how they'd be officially coordinated.

Ah, thank you, I think we can fold those changes into this change log entry.

Does this discussion about adding a message-based interrupt into KernelClient warrant a delay? ipython/ipykernel#741 (comment)

Yes, let's hold off a bit

@blink1073
Copy link
Contributor Author

Actually, I'll make a separate transition guide and link to it to keep the changelog more focused

@blink1073
Copy link
Contributor Author

I've updated the changelog to refer to the new migration guide from #681.

@blink1073
Copy link
Contributor Author

@ccordoba12, are you planning to address ipython/ipykernel#741 (comment) within the next couple days? If not we can plan to include it in a 7.1 release.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Steve.

@blink1073
Copy link
Contributor Author

I plan to cut 7.0 final release tomorrow

@blink1073 blink1073 merged commit b0caefd into changelog-e3614692febe11eba23449f48f5231ce Aug 19, 2021
@blink1073 blink1073 deleted the blink1073-patch-2 branch August 19, 2021 15:06
@blink1073
Copy link
Contributor Author

Release time!

@blink1073 blink1073 changed the title Update changelog for 7.0 Release Automated Changelog Entry for 7.0.0 on master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants