Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contain usage of nest-asyncio #666

Closed

Conversation

SylvainCorlay
Copy link
Member

No description provided.

@SylvainCorlay SylvainCorlay marked this pull request as draft July 9, 2021 14:41
@SylvainCorlay SylvainCorlay force-pushed the contain-nest-asyncio branch 17 times, most recently from 9a4c3c4 to 81abc8c Compare July 9, 2021 23:27
@kevin-bates
Copy link
Member

Hi @SylvainCorlay. The changes look good to me so far. Prior to merge, could you please add a description that includes the reason for these changes and what impact they might have on existing applications that subclass or use KernelManager directly? I suspect they too would need to move to BlockingKernelManager. Given this will likely be slated for 7.x (correct?), I don't see that being an issue.

Copy link

@IrfanJaya56 IrfanJaya56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073
Copy link
Contributor

nest-asyncio usage was removed in #835

@blink1073 blink1073 closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants